[–] [S] 2 points 3 years ago

Aside from the unusual cell there’s also a wheel instead of a switch, and an unconventional unlock:

When unlocking, it needs to be rotated rapidly for more than 60 degrees at one time

  • source
  • [–] 4 points 3 years ago (1 child)

    Although your current role wouldn’t seem very senior at a large organizational, “senior“ is a relative term and at this company it seems like you are the engineer with ownership responsibilities over the end-to-end software development of a production system. So it might still be reasonable to use a senior title if there are other benefits

  • source
  • parent
  • context
  • [–] 1 point 3 years ago

    Good point and I agree with the downsides. Giving admins more granular ways of hiding content sounds healthy.

    There’s also the important distinction between admins finding opinions on the other instance “disagreeable” and muting vs. illegal content in the instance server’s jurisdiction and those of the admins. Defederating the whole instance does seem harsh if the problem is within specific communities only and doesn’t deal with illegal content.

    Difficult problem!

  • source
  • parent
  • context
  • [–] 8 points 3 years ago (2 children)

    Feels odd for admins be able to prevent users from seeing content

    My understanding is those admins aren't just allowing users to view it but also allowing copies of the federated data to be stored on the server those admins are responsible for, so for certain types of content it seems really important to be implemented in this way.

  • source
  • parent
  • context
  • [–] 1 point 3 years ago (3 children)

    Sorry for the extraneous information about the ifdef. The important part was whether adding this extra check would fix the bug in the same way as deleting the original line did.

    I can’t find where arg should be equals to 0… steady_state always call with arg <> 0

    From what I could assume in the comments, this refers to the very first state in that steady-state (“first frame”) right when you have done 4H. Then it sets the current level to the appropriate turbo (set_level_and_therm_target).

    Your bug would be that it never set the level to turbo because it never executed set_level_and_therm_target because ! arg evaluates to false.

    Your bug fix was to delete the check, but that means that every instant it will keep trying to set the level to turbo instead of just setting it during the first frame and then maintaining the steady-state.

    My potential fix was to add something so that the statement if (! arg) || (! channel_has_args(cfg.channel_mode) would evaluate to true during the first frame so it can then call set_level_and_therm_target exactly once.

    @SammysHP@feddit.de (if you have a moment) does this seem close to the mark?

  • source
  • parent
  • context
  • [–] 1 point 3 years ago (3 children)

    Speaking of testing locally - how do folks test code changes? Actually flash them to driver, or is there some kind of way of simulating the inputs and outputs? I’m guessing there isn’t an Anduril emulator.

  • source
  • [–] 1 point 3 years ago* (5 children)

    I don’t own a multi-channel, but I did see something that looks interesting in the code (not familiar with the codebase and haven’t worked with C much):

    Could be a red herring but the function channel_has_args looks kind of like it might be doing the same work as if(!arg) for single-channel. Again this could be totally wrong but IF that were the case, then I’d expect that adding to the if statement could potentially help catch this? Like

    if (! arg) || (! channel_has_args(cfg.channel_mode) .

    Also in following the code style the actual statement would also need to include an IFDEF for multi-channel-config but maybe not necessary for you test locally?

  • source
  • parent
  • context
  • [–] 1 point 3 years ago (7 children)

    Good question, just wanted to point out your link

    [https://bazaar.launchpad.net/~toykeeper/flashlight-firmware/multi-channel/view/head:/ToyKeeper/spaghetti-monster/anduril/ramp-mode.c#L423]()

    markdown is broken but copy-pasting the url works.

  • source
  • view more: ‹ prev next ›