19
Anduril 2 (Multi-channel) - Momentary Turbo 3H/4H don't work (lemmy.world)
submitted 3 years ago* (last edited 3 years ago) by to c/flashlight@lemmy.world
15 comments fedilink hide all child comments
 

Hi Anduril user's !

I noticed that the momentary turbo does not work for 4H from the "ON" state (3H for those who do not have tint ramping).

To fix it, I have to comment out line 423:

if (! arg) { // first frame only, to allow thermal regulation to work

[https://bazaar.launchpad.net/~toykeeper/flashlight-firmware/multi-channel/view/head:/ToyKeeper/spaghetti-monster/anduril/ramp-mode.c#L423

Do you have the same behavior?

Thank you and good day

you are viewing a single comment's thread
view the rest of the comments
[–] 1 point 3 years ago (2 children)

Speaking of testing locally - how do folks test code changes? Actually flash them to driver, or is there some kind of way of simulating the inputs and outputs? I’m guessing there isn’t an Anduril emulator.

  • permalink
  • fedilink
  • source
  • hideshow 4 child comments
    •
  • [–] 3 points 3 years ago (1 child)

    Yes, you could (theoretically) use an emulator for the microcontroller. I tried it a few times. And it isn't fun. It takes a lot of effort to simulate all inputs, outputs are hard to interpret and all kind of effects of the real light aren't reproduced.

    In reality we flash the build onto a flashlight and try it. Sometimes it's only a prototype, disassembled. And rarely it's an actual devboard which has all relevant parts of the flashlight nicely accessible (basically the microcontroller with required electronics, regulated power supply, low power LED to see the output, several LEDs for aux and button and the switch itself).

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 2 child comments
    •
  • [–] 1 point 3 years ago

    That makes sense that it’s easier to flash directly since there are so many different parts and variations to the actual destination hardware.

    I read that one of Toykeeper’s original design decisions was to separate out the generic UI code from the specific code that interfaces with the hardware (being vague due to lack of knowledge). Maybe it would be possible to incorporate some testing code that only evaluates the user inputs compared to expected outputs within the Anduril layer? Such as a single state transition like “when multi-channel is enabled and user selects 4H, selected output level is equal to turbo”. Such a test could be indicate unexpected behavior when UI code is being customized.

    Just adding to the imaginary backlog here!

  • permalink
  • fedilink
  • source
  • parent