top 50 comments

sorted by: hot top controversial new old
[–] 196 points 2 years ago (5 children)

As your future colleague wondering what the hell that variable is for, thanks Go.

  • source
  • hideshow 10 child comments
  • [–] 25 points 2 years ago (6 children)

    A quick "find all references" will point out it's not used and can be deleted if it accidentally gets checked in but ideally, you have systems in place to not let it get checked into the main branch in the first place.

  • source
  • parent
  • hideshow 7 child comments
  • load more comments (5 replies)
  • [+] 121 points 2 years ago* (last edited 2 years ago) (11 children)
  • load more comments (9 replies)
    [–] 83 points 2 years ago* (last edited 2 years ago) (3 children)

    Sometimes I think Go was specifically made for Google to dictate its own preferences on the rest of us like some kind of power play. It enforces one single style of programming too much.

  • source
  • hideshow 5 child comments
  • [–] 20 points 2 years ago (3 children)

    From what I've heard from Google employees Google is really stringent with their coding standards and they usually limit what you can do with the language. Like for C++ they don't even use half the fancy features C++ offers you because it's hard to reason about them.

    I guess that policy makes sense but I feel like it takes out all the fun out of the job.

  • source
  • parent
  • hideshow 4 child comments
  • load more comments (2 replies)
  • [–] 18 points 2 years ago (2 children)

    Is this a hard error? Like it doesn't compile at all?

    Isn't there something like #[allow(unused)] in Rust you can put over the declaration?

  • source
  • parent
  • hideshow 4 child comments
  • [–] 27 points 2 years ago (5 children)

    Yes it is a hard error and Go does not compile then. You can do _ = foobar to fake variable usage. I think this is okay for testing purposes.

  • source
  • parent
  • hideshow 6 child comments
  • load more comments (4 replies)
  • load more comments (1 reply)
    [–] 82 points 2 years ago (1 child)

    Go is not a programming language. It's an angry rant of a bored Google engineer.

  • source
  • hideshow 2 child comments
  • [–] 49 points 2 years ago* (last edited 2 years ago) (11 children)

    If this language feature is annoying to you, you are the problem. You 👏are 👏 the 👏 reason 👏 it 👏 exists.

    I worked in places where the developers loaded their code full of unused variables and dead code. It costs a lot of time reasoning about it during pull request and it costs a lot of time arguing with coworkers who swear that they’re going to need that code in there next week (they never need that code).

    This is a very attractive feature for a programming language in my opinion.

    PS: I’m still denying your pull request if you try to comment the code instead.

    ❗️EDIT: A lot of y’all have never been to programming hell and it shows. 🪖 I’m telling you, I’ve fixed bayonets in the trenches of dynamically typed Python, I’ve braved the rice paddies of CICD YAML mines, I’ve queried alongside SQL Team Six; I’ve seen things in production, things you’ll probably never see… things you should never see. It’s easy to be against an opinionated compiler having such a feature, but when you watch a prod deployment blow up on a Friday afternoon without an easy option to rollback AND hours later you find the bug after you were stalled by dead code, it changes you. Then… then you start to appreciate opinionated features like this one. 🫡

  • source
  • hideshow 17 child comments
  • [–] 83 points 2 years ago (8 children)

    That's 👏 what 👏 CI 👏 is 👏 for

    Warn in dev, enforce stuff like this in CI and block PRs that don't pass. Go is just being silly here, which is not surprising given that Rob Pike said

    Syntax highlighting is juvenile. When I was a child, I was taught arithmetic using colored rods. I grew up and today I use monochromatic numerals.

    The Go developers need to get over themselves.

  • source
  • parent
  • hideshow 10 child comments
  • [–] 19 points 2 years ago

    Yeah, insisting on things like a variable being used will result in people using work arounds. It won't result in people not doing it.

    Then, because people trust the language to police this rule, the work-arounds and debug code will get committed.

    func main() {  
        test := true  
    }  
    

    Oops, golang doesn't like that.

    func main() {  
        test := true  
        _ = test  
    }
    

    Perfectly cromulent code.

    If they really wanted to avoid people having unused variables, they should have used a naming convention. Any variable not prefixed by "_" or "_debug_" or whatever has to be used, for example. Then block any code being checked in that still contains those markers.

  • source
  • parent
  • [–] 18 points 2 years ago (1 child)

    reading my code after being up for 18 hours and having my eyes glaze over trying to parse the structure of my monochromatic code but then I remember Rob Pike said syntax highlighting is juvenile so I throw my head against that wall for another 3 hours

  • source
  • parent
  • hideshow 2 child comments
  • load more comments (6 replies)
  • [–] 59 points 2 years ago* (6 children)

    That's a problem with your workplace, not the language nor OP.
    You could have a build setting for personal development where unused variables are not checked, and then a build setting for your CI system that will look for them. It gives you freedom to develop the way you want without being annoyed when you remove something just to test something, but will not merge your PR unless the stricter rules are met.

  • source
  • parent
  • hideshow 6 child comments
  • load more comments (6 replies)
  • [–] 30 points 2 years ago

    That's what warnings are for. The jokes about programmers ignoring warnings are outdated - we live in an age where CIs run linters and style checkers on pull requests, there is no reason for a CI to not automatically reject code that builds with warnings.

  • source
  • parent
  • [–] 16 points 2 years ago

    It costs a lot of time reasoning about it during pull request and it costs a lot of time arguing with coworkers who swear that they’re going to need that code in there next week (they never need that code).

    You should go to your team leader and ask them to enforce a coding standard. I agree with other commenters that said this should be a warning instead of an error.

  • source
  • parent
  • load more comments (5 replies)
    [–] 49 points 2 years ago (1 child)

    Also Go: exceptions aren't real, you declare and handle every error at every level or declare that you might return that error because go fuck yourself.

  • source
  • hideshow 2 child comments
  • [–] 53 points 2 years ago (4 children)

    Because that's sane and readable?

  • source
  • parent
  • hideshow 7 child comments
  • [–] 20 points 2 years ago (1 child)

    It's better than "invisible" exceptions, but it's still the worst "better" version. The best solution is some version of the good old Result monad. Rust has the BEST error handling (at least in the languages i know). You must handle Errors, BUT they are just values, AND there's a easy, non-verbose way of passing on the error (the ? operator).

  • source
  • parent
  • hideshow 1 child comment
  • load more comments (1 reply)
  • load more comments (1 reply)
  • [–] 32 points 2 years ago (1 child)

    And I fucking love it. Thank you Go!

  • source
  • hideshow 2 child comments
  • [–] 30 points 2 years ago

    lints that underline unused vars as errors, and not notes or warns are the worst lints..

  • source
  • [–] 29 points 2 years ago
    [–] 25 points 2 years ago

    OP never said he/she commits such code but wants to iterate, test, explore.

    Of course, unused var should not be part of a commit.

  • source
  • [–] 24 points 2 years ago (7 children)

    This makes me not want to use Golang at all.

  • source
  • hideshow 7 child comments
  • load more comments (7 replies)
    [–] 18 points 2 years ago

    you can assign it to itself and it’ll be just fine. can’t put a breakpoint right on it, but it works

  • source
  • [–] 14 points 2 years ago (2 children)

    I hate this in C++ when it does this with parameters of an overidden function. I don't need that specific parameter, but if I omit the variable name, I reduce readability.

  • source
  • hideshow 2 child comments
  • load more comments (2 replies)
    [–] 13 points 2 years ago

    The best part of these threads is no matter what someone comments, at least 2 people will reply either correcting or "clarifying" the original commenter.

    Lol

  • source
  • [–] 12 points 2 years ago

    Me when my wife wants to buy new clothes (her clothes are the variables)

  • source
  • [–] 12 points 2 years ago

    Comment the unused variable out and no security hole gets accidentally shipped.

  • source
  • load more comments
    view more: next ›