top 50 comments

sorted by: hot top controversial new old
[–] 97 points 2 years ago (5 children)
  • [–] 68 points 2 years ago (3 children)

    With 400 lines changed over 50 files

  • source
  • parent
  • hideshow 6 child comments
  • [–] 4 points 2 years ago

    Y tho??? Holy shit. Commits should be like functions. One thing and one thing only. Maybe a small group of files like the same change over multiple config files. 50 is insane to me.

  • source
  • parent
  • load more comments (2 replies)
    [–] 60 points 2 years ago* (last edited 2 years ago) (3 children)

    Every time I commit I have to look through git diff, figure out what the hell I actually did, come up with something intelligent to say about jt, possibly split the commit into multiple commits if I changed multiple things, do some shuffling with git reset and git add...

    For some reason all my personal projects are all like 4K SLoC with 50 total commits, all of which include apologies for not doing more smaller commits

  • source
  • hideshow 5 child comments
  • [–] 44 points 2 years ago (3 children)

    There's a bigger issue than your commit message if you don't even know what you just coded and are committing.

  • source
  • parent
  • hideshow 5 child comments
  • [–] 28 points 2 years ago* (last edited 2 years ago) (3 children)

    You see, sometimes I code something, go to bed before finishing it, come back, decide not to commit because then I'd have to think of a commit message and I just want to code, start working on an unrelated feature, do that for a couple days, get distracted by life stuff and put the project down for a few weeks/months, rinse and repeat, and then I finally get around to writing a commit message because I'm about to start a huge change and I want a restore point and I'm like. Okay, it's been like 3 months since my last commit, I'm pretty sure my code can now do something it couldn't 3 months ago but come on, I can't even remember what I had for lunch last Thursday

    I'm well aware this is terrible practice but I don't know how to stop doing it

  • source
  • parent
  • hideshow 4 child comments
  • [–] 20 points 2 years ago (2 children)

    Commit more often. Maybe work in a different feature branch, and don’t be afraid to commit your half-working crappy code. If it’s a personal project/fork, it’s totally acceptable to commit often with bad commit names and small unfinished changes: you can always amend/squash the commits later. That’s how I tend to work: create a new branch, work on the feature, rebase and merge (fast forward, no merge commit). Also, maybe don’t jump around working on random features :P

  • source
  • parent
  • hideshow 4 child comments
  • load more comments (2 replies)
  • load more comments (1 reply)
  • load more comments (1 reply)
    [–] 51 points 2 years ago (7 children)

    Just use What The Commit.

    You can also create a git alias:

    git config --global alias.yolo '!git add -A && git commit -m "$(curl --silent --fail https://whatthecommit.com/index.txt)"'

    Now you can just type 'git yolo' to create a commit!

  • source
  • hideshow 9 child comments
  • load more comments (5 replies)
    [–] 36 points 2 years ago (2 children)
  • [–] 13 points 2 years ago (1 child)
  • [–] 39 points 2 years ago (2 children)

    "patch mode" - Patch mode allows you to stage parts of a changed file, instead of the entire file. This allows you to make concise, well-crafted commits that make for an easier to read history.

  • source
  • parent
  • hideshow 3 child comments
  • [–] 14 points 2 years ago (2 children)

    Highly recommend throwing --patch on any git commands you're used to using. You will have the prettiest, most atomic fkn commit, I'm serious people will love you for it.

    I mean many people won't care, but the quality folk will notice and approve.

  • source
  • parent
  • hideshow 4 child comments
  • load more comments (1 reply)
  • [–] 21 points 2 years ago* (17 children)

    git commit -m “changed somethings “

    git push origin master

  • source
  • hideshow 18 child comments
  • load more comments (16 replies)
    [–] 11 points 2 years ago

    For me, it was my boss gave me a programming task which he knew would take hours or a day or two... and then 15 minutes later tells me to "switch focus" and do a menial task that any of my five coworkers could do 🤦‍♂️

  • source
  • [–] 11 points 2 years ago (1 child)

    I’m using Copilot for it right now. It works on half of the cases.

  • source
  • hideshow 2 child comments
  • [–] 10 points 2 years ago

    The usual reason would be "because coworkers"

  • source
  • [–] 9 points 2 years ago

    That's in any bloody workplace! Especially if there is o synergy between different teams.

  • source
  • [–] 8 points 2 years ago (1 child)

    do git commit -v and then just summarize the diff you have in your editor in a human readable form.

  • source
  • hideshow 2 child comments
  • [–] 10 points 2 years ago (1 child)

    Don't just summarize the content though, summarize the rationale or how things connect. I can read your diff myself to see what changed, I want to know the logical connections, the reason you did X and not Y, etc.

    Or just say "stuff" and provide that context in the PR description separately, no need to overdo the commit log on a feature branch if you're using squash merges from your PR.

  • source
  • parent
  • hideshow 2 child comments
  • [–] 8 points 2 years ago (1 child)
    load more comments (1 reply)
    [–] 7 points 2 years ago (4 children)

    Oh god I feel so called out. I wish I paid more attention to my commit messages but I’m usually too busy fixing the directory structure and refactoring. Sigh.

  • source
  • hideshow 4 child comments
  • load more comments (4 replies)
    [–] 5 points 2 years ago (2 children)

    You should not use -m, you should write commit body!

  • source
  • hideshow 3 child comments
  • load more comments (1 reply)
    load more comments
    view more: next ›