you are viewing a single comment's thread
view the rest of the comments
[–] 184 points 2 years ago* (10 children)

WHY IS THE HEALTH INPUT PARAMETER A GODDAMN STRING?????????????

Why are you passing ‘%’ inside said goddamn string?!?! Not to mention the static reference instead of the actual instance.

Shame on you

  • source
  • hideshow 20 child comments
  • [–] 6 points 2 years ago (4 children)

    The high level setter function should be made to handle both string and numeric values.

    If it contains "%" it's a percentage value.

    If it's a string without a "%" it's an absolute value and needs to be normalized.

    If it's a numeric value, it's an absolute value.

    If it's a numeric 100, it's 100%.

    If it's a subunitary numeric value, it's a percentage.

  • source
  • parent
  • hideshow 8 child comments
  • [–] 27 points 2 years ago (1 child)

    yeah I’m gonna go ahead and reject your PR, please change this function to accept a decimal value between 0 and 1

  • source
  • parent
  • hideshow 2 child comments
  • [–] 12 points 2 years ago (2 children)

    Ironically, the worst thing I ever saw a coworker do was to change a function that accepted an Integer value between 0 and 32767 to one that accepted a Float between 0.0 and 1.0. Perfectly sensible change except that it resulted in a 120 mph knuckleball fired a foot above a 10 year old kid's head, followed by a fist fight between the client and my boss.

  • source
  • parent
  • hideshow 4 child comments
  • [–] 11 points 2 years ago (1 child)

    That sounds like something that should have been caught by QA, integration tests or unit tests long before it was launching balls at ten year olds.

  • source
  • parent
  • hideshow 2 child comments
  • [–] 6 points 2 years ago (1 child)

    Yes, testing the new Little League control module on a field full of Little Leaguers was not the best plan.

  • source
  • parent
  • hideshow 2 child comments
  • [–] 3 points 2 years ago (2 children)

    What is a little league control module?

  • source
  • parent
  • hideshow 4 child comments
  • [–] 4 points 2 years ago (1 child)

    Oldman.setHealth("dicktits"); //normalize pls

    Oldman.setHealth("-100±1%"); //make percentage pls

    Oldman.setHealth(0.0); //it is subunitary, but undefined behavior - will it access the 'numeric value' overload, or the 'subunitary numeric value' overload?

    Don't write your own code just yet.

  • source
  • parent
  • hideshow 2 child comments
  • [–] 3 points 2 years ago

    Oldman.setHealth(“dicktits”); //normalize pls

    0

    Oldman.setHealth(“-100±1%”); //make percentage pls

    Reject operations.

    Use absolute number to remove the minus. Math.abs()

    Oldman.setHealth(0.0); //it is subunitary, but undefined behavior - will it access the ‘numeric value’ overload, or the ‘subunitary numeric value’ overload?

    Same result either way, so whatever if branch is first.

    Understand the purpose. If you want to kill the old man with 0, then there's no point to leaving it as 0.9%, understand the non-linear characteristics of life and death.

    When you're dealing with the low level functions, sure, you can keep it simple. When you're reaching the surface of user input, you're either going to waste time with validation and error reporting, or you're going to waste time with interfaces that can handle more shit without complaining. There's no fool proof either way, but good luck pissing users off with endless docs.

    Don’t write your own code just yet.

    If your goal in programming is just to be a traffic cop between the user input and the database, all you're doing is building a virtual bureaucracy, the kind that people really hate and is easily generated with coding tools. Or you're just deferring the "smoothing out" burden to the UI developers.

  • source
  • parent
  • [–] 2 points 2 years ago (1 child)

    Yeah, in Ren'py games usually it's character_health=100 or something.

  • source
  • parent
  • hideshow 2 child comments
  • [–] 3 points 2 years ago

    Yes absolutely, the parameter even if not in a strongly typed language should be a specific number and the unit should be implied. Overload the method to support different units if necessary or provide a unit as an additional parameter instead of forcing the method to parse the string for any unit type hints that may or may not be there

  • source
  • parent