top 50 comments

sorted by: hot top controversial new old
[–] 79 points 2 years ago (6 children)

No closing semicolon, anyone got any extras to throw on this thing?

  • source
  • hideshow 11 child comments
  • [–] 17 points 2 years ago* (last edited 2 years ago) (2 children)

    At the very least I'd try to clean up that fuzzy condition on behavior to anticipate any bad or inconsistent data entry.

    WHERE UPPER(TRIM(behavior)) = 'NICE'

    Depending on the possible values in behavior, adding a wildcard or two might be useful but would need to know more about that field to be certain. Personally I'd rather see if there was a methodology using code values or existing indicators instead of a string, but that's often just wishful thinking.

    Edit: Also, why dafuq we doing a select all? What is this, intro to compsci? List out the values you need, ya heathen ;)

    (This is my favorite Xmas meme lol)

  • source
  • parent
  • hideshow 4 child comments
  • [–] 4 points 2 years ago (1 child)

    You need semicolons if it is a script with multiple commands to separate them. It is not needed for a single statement, like you would use in most language libraries.

  • source
  • parent
  • hideshow 2 child comments
  • [–] 4 points 2 years ago (2 children)

    Honest question, which ones wouldn't it work with? Most add a semicolon to the end automatically or have libraries and interfaces saved me a million times?

  • source
  • parent
  • hideshow 3 child comments
  • [–] 4 points 2 years ago (2 children)

    Other reply s accurate but it's always a good practice to include the semicolon else you can get

    "Bobby tables'ed" look that xkcd comic up

  • source
  • parent
  • hideshow 3 child comments
  • [–] 8 points 2 years ago (1 child)

    I'm not sure how including a final semicolon can protect against an injection attack. In fact, the "Bobby Tables" attack specifically adds in a semicolon, to be able to start a new command. If inputs are sanitized, or much better, passed as parameters rather than string concatenated, you should be fine - nothing can be injected, regardless of the semicolon. If you concatenate untrusted strings straight into your query, an injection can be crafted to take advantage, with or without a semicolon.

  • source
  • parent
  • hideshow 2 child comments
  • load more comments (1 reply)
  • load more comments (1 reply)
  • load more comments (1 reply)
    [–] 54 points 2 years ago (1 child)

    That SELECT and WHERE are all caps, but from is not is bugging me.

    I don't care if you choose to uppercase keywords or lowercase, but consistency please.

    Also, great, love it.

  • source
  • hideshow 2 child comments
  • [–] 36 points 2 years ago (12 children)

    Guess that settles the debate, we got to pronounce it "sequel" then to optimally match syllables

  • source
  • hideshow 16 child comments
  • [–] 11 points 2 years ago (2 children)
  • load more comments (8 replies)
    [–] 30 points 2 years ago

    dammit bobby tables is on the naughty list again

  • source
  • [–] 29 points 2 years ago (2 children)

    wait until it hits little bobby tables...

    https://xkcd.com/327/

  • source
  • hideshow 4 child comments
  • [–] 9 points 2 years ago (1 child)

    He drops when you are sleeping. He drops when you’re awake.

  • source
  • parent
  • hideshow 2 child comments
  • [–] 2 points 2 years ago

    Come they told me, pa rum pum pum pum A new born King to see, pa rum pum pum pum Our finest gifts we bring, pa rum pum pum pum To lay before the King, pa rum pum pum pum, rum pum pum pum, rum pum pum pum,

    So to honor Him, pa rum pum pum pum, When we come.

    Little Bobby, pa rum pum pum pum I am a poor boy too, pa rum pum pum pum I have no gift to bring, pa rum pum pum pum That's fit to give the King, pa rum pum pum pum, rum pum pum pum, rum pum pum pum,

    Shall I play for you, pa rum pum pum pum, On my unsanitized database inputs?

    ...

  • source
  • parent
  • [–] 27 points 2 years ago

    I can't be the only one disappointed by the lack of an order by clause after being told the list was being sorted (twice!)...

  • source
  • [–] 14 points 2 years ago

    Query OK, 0 rows affected

  • source
  • [–] 13 points 2 years ago (4 children)

    Can anyone recommend a cheap receipt printer that takes pictures from a pc or phone? I want to print mtg tokens on the fly.

  • source
  • hideshow 7 child comments
  • load more comments (1 reply)
    [–] 12 points 2 years ago (1 child)

    I was reading that to the tune of the chorus of The Distance by Cake. It worked until the last line.

  • source
  • hideshow 1 child comment
  • load more comments (1 reply)
    [–] 11 points 2 years ago (1 child)

    The beginning maps perfectly to "The Distance" by Cake and I was singing along to that tune as I read.

  • source
  • hideshow 2 child comments
  • [–] 11 points 2 years ago* (last edited 2 years ago) (1 child)

    He sees you when you’re bashing

    He’s hacked your VPN

  • source
  • hideshow 2 child comments
  • [–] 9 points 2 years ago

    Love it keep em coming

  • source
  • [–] 3 points 2 years ago

    I started this in my head sounding like the singer from Cake.

  • source
  • load more comments
    view more: next ›