122
Is there a place where you can request code reviews on opensource software? (programming.dev)
submitted 2 years ago by to c/programming@programming.dev
36 comments fedilink hide all child comments
 

Many of us write opensource code in a void: nobody ever looks at it, uses it nor reviews it. We are the only users and authors.

In order to improve, where can we get our code reviewed? I don't mean professionally, just from like-minded individuals.

you are viewing a single comment's thread
view the rest of the comments
[–] 4 points 2 years ago (1 child)

I've actually found his blog where he talks about this "optimistic merge"

http://hintjens.com/blog:106

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 2 child comments
    •
  • [–] 4 points 2 years ago (2 children)

    There's a number of them as the idea grows. See also the C4 process RFC

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 4 child comments
    •
  • [–] [S] 2 points 2 years ago (1 child)

    mbin (fork of kbin) is currently trying to implement the process.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 2 child comments
    •
  • [–] 1 point 2 years ago (1 child)

    It's great to see the attempt and also an example of what the C4 guidelines are made to avoid.

    Notice how many comments are little nitpicks about this and that. Completely stalling the commit and getting further away from the original point of C4 which is to reduce contributor friction and avoid these kind of endless discussions on PRs.

    I don't want to be too critical because some of that is a clear lack of understanding of the motivations of C4 which is explained more thoroughly in Pieter's blog posts. You don't want to adopt a contributor guidelines that you don't understand of course.

    IMO it's better just to implement it as-is and start using it in practice rather than bikeshedding.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 2 child comments
    •