you are viewing a single comment's thread
view the rest of the comments
[–] 6 points 2 years ago* (last edited 2 years ago) (3 children)

When I talk about alignment it's not about function arguments, but values, "=" signs and such. You simply cannot use tabs for that because alignment must be fixed and indentation independent:

CreateOrderRequest(
    user,
    productDetails     => order.detail,
    pricingCalculator  => DEFAULT_CALCULATOR,
    order              => order.internalNumber)
  • source
  • parent
  • hideshow 6 child comments
  • [–] 10 points 2 years ago* (last edited 2 years ago) (1 child)

    I normally avoid that too, I find it hurts readability more than helps, plus a proper IDE will separate it with color anyway.

    But yeah, the newline comment doesn't apply to this.

  • source
  • parent
  • hideshow 2 child comments
  • [–] 6 points 2 years ago (1 child)

    This kind of "manual" alignment should be avoided for many reasons including the fact that adding/removing/changing of one parameter here may force you to modify multiple lines which on it's own is annoying but this will also show up in the diff during review making it harder to grep what was actually changed.

  • source
  • parent
  • hideshow 2 child comments