164
Tabs are objectively better than spaces - gomakethings.com (gomakethings.com)
submitted 2 years ago by to c/programming@programming.dev
176 comments fedilink hide all child comments
you are viewing a single comment's thread
view the rest of the comments
[–] 17 points 2 years ago* (last edited 2 years ago) (2 children)

Not like that, lol

Just saying, instead of this monstrosity

CreateOrderRequest(user,
                   productDetails,
                   pricingCalculator,
                   order => order.internalNumber)

Just use

CreateOrderRequest(
    user,
    ...

Putting the first argument on a separate line.

Same if you have an if using a bunch of and (one condition per line, first one on a new line instead of same line as the if) and similar situations.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 4 child comments
    •
  • [–] 8 points 2 years ago

    People seem to have a real issue with using new lines and I've never quite understod why.

    It feels like a lot of those people are using notepad like applications instead of coding focused ones with collapsible regions etc.

  • permalink
  • fedilink
  • source
  • parent
  • [–] 6 points 2 years ago* (last edited 2 years ago) (3 children)

    When I talk about alignment it's not about function arguments, but values, "=" signs and such. You simply cannot use tabs for that because alignment must be fixed and indentation independent:

    CreateOrderRequest(
    user,
    productDetails     => order.detail,
    pricingCalculator  => DEFAULT_CALCULATOR,
    order              => order.internalNumber)
  • permalink
  • fedilink
  • source
  • parent
  • hideshow 6 child comments
    •
  • [–] 10 points 2 years ago* (last edited 2 years ago) (1 child)

    I normally avoid that too, I find it hurts readability more than helps, plus a proper IDE will separate it with color anyway.

    But yeah, the newline comment doesn't apply to this.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 2 child comments
    •
  • [–] 6 points 2 years ago (1 child)

    This kind of "manual" alignment should be avoided for many reasons including the fact that adding/removing/changing of one parameter here may force you to modify multiple lines which on it's own is annoying but this will also show up in the diff during review making it harder to grep what was actually changed.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 2 child comments
    •