31
Looks like the sede situation is being worked on (github.com)
submitted 3 years ago* by to c/rust@programming.dev
15 comments fedilink hide all child comments

all 15 comments

sorted by: hot top controversial new old
[–] 13 points 3 years ago (3 children)

My personal gut feeling: the maintainer will just shoot this attempt down and close the PR.

Happy to be proven wrong here though.

  • permalink
  • fedilink
  • source
  • hideshow 6 child comments
    •
  • [–] 8 points 3 years ago (2 children)

    dtolnay isn't the only maintainer though. oli-obk is also a maintainer and is participating in the discussions on the PR.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 4 child comments
    •
  • [–] 1 point 3 years ago (1 child)

    Has dtolnay shown a strong sentiment towards having it be on always? I can't imagine there's much reason not to make it configurable.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 2 child comments
    •
  • [–] 3 points 3 years ago (2 children)

    The precompiled implementation is the only supported way to use the macros that are published in serde_derive. If there is implementation work needed in some build tools to accommodate it, someone should feel free to do that work

    ~ dtolnay (source)

    That sounds like he doesn't like to (re-)introduce any other options.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 4 child comments
    •
  • [–] 3 points 3 years ago (1 child)

    That seems a bit concerning. At first I was under the impression the binary was compiled on the user's machine, but once I saw that it's distributed with serde I can see why people are upset.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 2 child comments
    •
  • [–] 3 points 3 years ago* (last edited 3 years ago)

    The precompiled implementation is the only supported way to use the macros that are published in serde_derive

    That statement is straight up gaslighting.

    The precompiled binary is only provided for one platform, Linux. Windows does not use a precompiled binary but compiles its own from the source. How can he claim it's the "only supported way", when for most platforms he is doing it another way? Also, the crate, throughout most of its life, has been doing it another way.

  • permalink
  • fedilink
  • source
  • parent
    • [–] 8 points 3 years ago (1 child)

    So, the general unsuspecting public will still be executing this potentially-malicious binary, and only those in the know will be able to avoid it?

  • permalink
  • fedilink
  • source
  • hideshow 2 child comments
    •