85
Unicode tricks in pull requests: Do review tools warn us? (semanticdiff.com)
submitted 2 years ago by to c/programming@programming.dev
18 comments fedilink hide all child comments

all 20 comments

sorted by: hot top controversial new old
[–] 44 points 2 years ago (3 children)

Homoglyphs? Invisible text? Bidirectional text? Just highlight every line that goes beyond ASCII with yellow warning colors and require to vet it. Maybe make localization data an exception.

  • permalink
  • fedilink
  • source
  • hideshow 6 child comments
    •
  • [–] 12 points 2 years ago (3 children)

    This doesn't work for code bases written in non-English languages. Especially east asian languages.

    Any line containing an identifier that is also a word would be highlighted.

    More and more programming languages are supporting unicode identifiers for this use case.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 6 child comments
    •
  • [–] 11 points 2 years ago (2 children)

    So it won't work for 0.0001% of all github projects.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 4 child comments
    •
  • [–] 6 points 2 years ago

    I'd suggest to have the occasional look at the "most popular repos" ranking. It's about 50% Chinese.

    Super-interesting sometimes as it shows completely different tech trends.

  • permalink
  • fedilink
  • source
  • parent
  • [–] 6 points 2 years ago (2 children)

    Very simple solution actually. Here I was thinking we'd need AI to solve it.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 4 child comments
    •
    • [–] 15 points 2 years ago (3 children)

    Website really struggled on mobile. Anytime I swipe to view the longer code lines in the code blocks it would open the sidebar. Very annoying.

  • permalink
  • fedilink
  • source
  • hideshow 6 child comments
    •
    • [–] 10 points 2 years ago

    TL;DR: you could adopt good programming practices like "don't shadow mutable state" and "put constants first in a comparison" or you can pay us money so we show you obscure attempts to exploit your bad programming in code review ... maybe ...

  • permalink
  • fedilink
  • source
    •
    [–] 3 points 2 years ago

    Very interesting read

  • permalink
  • fedilink
  • source
    •