Python

hideshow 4 child comments

parent

[–] pankuleczkapl@lemmy.dbzer0.com 4 points 2 years ago (1 child)

You accidentally added a dot at the end of the link. Here's the fixed one https://google.github.io/styleguide/cppguide.html

parent

[–] cbarrick@lemmy.world 20 points 2 years ago (1 child)

I intentionally added a period because it was the end of a sentence.

If your Lemmy app messed it up, then that's a bug in its markdown parser.

parent

[–] rhymepurple@lemmy.ml 3 points 2 years ago (1 child)

I'm curious about this. The source text of your comment appears that your comment was just the URL with no markdown. For your comment about a markdown parsing bug to be true, shouldn't the URL have been written in markdown with []() notation (or a space between the URL and the period) since a period is a valid URL character? For example, instead of typing https://google.github.io/styleguide/cppguide.html., should [https://google.github.io/styleguide/cppguide.html.](https://google.github.io/styleguide/cppguide.html) have been typed?

parent

https://spec.commonmark.org/0.31.2/#autolinks

[–] cbarrick@lemmy.world 4 points 2 years ago* (last edited 2 years ago) (1 child)

Huh. This got me curious.

Yes, I did just type a bare URL. Every mature markdown parser I've used turns this into a link, and appropriately handles trailing punctuation.

So I went to the spec, and it's explicitly called out that this is not an autolink. Autolinks must be explicitly surrounded with angle brackets <>.

So yeah \shrug.

Edit to be clear: This means that both of our markdown parsers are wrong relative to the commonmark spec. But I'll argue that if a parser is going to attempt to autolink this, then handling trailing punctuation is better than not.

parent

[–] rhymepurple@lemmy.ml 2 points 2 years ago

I did not know about autolinks - thanks for the link!

It is interesting how different parsers handle this exact situation. I usually am cautious about it because I typically am not sure how it will be handled if I am not explicit with the URL and additional text.

parent

[–] wewbull@feddit.uk 1 point 2 years ago (1 child)

Do you think a style guide is enough for an open source code base? Contributions could be coming from lots of directions, and the code review process to enforce a style guide is going to be a lot of work. Even rejecting something takes time.

parent

[–] balder1993@programming.dev 5 points 2 years ago (1 child)

This kind of thing can be easily automated nowadays. It’s not really a problem.

parent

[–] sugar_in_your_tea@sh.itjust.works 2 points 2 years ago

Yup, we do it for Python and Javascript at work, and I do it on my Rust projects (and my older C projects). I don't see why C++ should be any more difficult.