Short but honestly good advise to rather pull boolean checks apart and re-group them as they make sense in the context of the given situation you're checking for.

I started doing this when building an alert-check system for the company I'm working for right now, and it really helps organize what is a pre-condition, what a syntactical requirement, etc etc.

you are viewing a single comment's thread
view the rest of the comments
[–] 21 points 2 years ago (5 children)

I've had at least one code reviewer ask me to put all the logic in the if ... line rather than use a variable or two in order to "simplify code by reducing the number of variables."

At the very least, this article helped me confirm my own bias of "that guy is a moron" and I can send this article to him the next time he reviews my code.

  • source
  • parent
  • hideshow 10 child comments
  • [–] 1 point 2 years ago (1 child)

    Well it actually depends.

    Does it make the code more readable? Like you have several if statements using the same things (and/or else if)? Yeah then it's probably good.

    If you have an if (work.lengt() == 0 && stacked_work.length() == 0) and that's it, probably not. Depending of whats happining then of course.

    Be creative guys! But also dont be too creative :-) Think about the poor coder doing something with all that in a year or two, let's make his life less miserable (It's probably you, too).

  • source
  • parent
  • hideshow 2 child comments