120
isBooleanTooLongAndComplex (testing.googleblog.com)
submitted 2 years ago by to c/programming@programming.dev
22 comments fedilink hide all child comments
 

Short but honestly good advise to rather pull boolean checks apart and re-group them as they make sense in the context of the given situation you're checking for.

I started doing this when building an alert-check system for the company I'm working for right now, and it really helps organize what is a pre-condition, what a syntactical requirement, etc etc.

you are viewing a single comment's thread
view the rest of the comments
[–] 8 points 2 years ago (1 child)

Good advice, clear, simple and to the point.

Stated otherwise: "whenever you need to add comments to an expression, try to use named intermediate variables, method or free function".

  • permalink
  • fedilink
  • source
  • hideshow 2 child comments
    •
  • [–] 8 points 2 years ago (2 children)

    Sometimes this can help, but lately I've been running into the opposite problem where people have been following this advice to such a degree that one cannot ever figure out what is going on without having to constantly jump around to find the actual code involved in doing something.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 4 child comments
    •
  • [–] [S] 3 points 2 years ago

    Ah I hate that, too. It speaks of bad abstraction, over eager abstraction or unnecessary coupling that is the hidden behind this. Difficult to fix though without essentially starting over.

  • permalink
  • fedilink
  • source
  • parent
  • [–] 2 points 2 years ago

    I absolutely agree that method extraction can be abused. One should not forget that locality is important. Functionnal idioms do help to minimise the layer of intermediate functions. Lamda/closure helps too by having the function much closer to its use site. And local variables can sometime be a better choice than having a function that return just an expression.

  • permalink
  • fedilink
  • source
  • parent