31
A bit frustrated with my team and CSS (lemmy.dbzer0.com)
submitted 2 years ago by to c/webdev@programming.dev
16 comments fedilink hide all child comments
 

I was recently tasked with rewriting the base CSS for an inventory/project management system, creating a set of reusable components designed to match, using an open/close approach. These were based on a pretty strict specification provided by one of our designers, who unfortunately left.

The implementation went well, but I've run into a bit of a problem. Quite often the team members make changes directly to the base class in the new base CSS file, rather than extending it, creating a new one, or using each system area's dedicated stylesheet file.

One of the more recent changes involved removing a grid-gap property from a rule from the base CSS, affecting a lot more than the single UI element the team member was working on.

Should I approach the team about this?

I haven't mentioned anything yet, but have noticed our QA team putting in more bugs about UI elements looking odd

you are viewing a single comment's thread
view the rest of the comments
[–] 5 points 2 years ago (3 children)

  1. passive aggressive email

  2. let qa bust them

  3. collective email reminder to the whole team not to edit the base class, variation of #1

  4. fix it yourself and say nothing, snitches get stitches

  5. snitch

  6. create a copy of the base further down so it just overwrites their changes -- I forget if this works, maybe make a copy above too just to cover your angles

  7. ask them to find the bugs in someone else's commits and see if they fix their own shit

  • permalink
  • fedilink
  • source
  • hideshow 6 child comments
    •
  • [–] 2 points 2 years ago (1 child)

    You seem to have a specific set of goals in mind. Please share what those goals are.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 2 child comments
    •