In general, you don't want a player to loser their powers. But if you can turn the threat of losing their powers into a plotline, then that's awesome. Warlocks losing powers for breaking contracts is bad. Warlocks having to fend off eldritch repo folks for breaking contracts is good.