106
I checked whether well-known dev tools companies actually require code review before merging to main. Most don't (codatus.com)
submitted 2 months ago by to c/programming@programming.dev
14 comments fedilink hide all child comments
 

I scanned the public repos of 128 YC-backed dev tools companies, 6,195 repos in total. I expected the companies building our tooling to enforce the basics on themselves. Only 2 of the 128 require any status check to pass before merging.

you are viewing a single comment's thread
view the rest of the comments
[–] [S] 6 points 2 months ago (1 child)

Right? The part that surprised me was that most of them turn branch protection ON and then don't require any check to pass. So the gate is there, it just doesn't gate anything. Makes me wonder if private repos are the same or if the public ones just get less attention.

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 2 child comments
    •
  • [–] 12 points 2 months ago (2 children)

    Not a start up, but we require code review, even though it is not enforced via rules, to allow emergency overrides.

    Gets used maybe once every 300 pull requests though.

    Convention over configuration is a thing - so maybe look into their actual merge behavior?

  • permalink
  • fedilink
  • source
  • parent
  • hideshow 4 child comments
    •
  • [–] 6 points 2 months ago

    My old workplace had the same'ish. The developer team who owned the service had rights to disable branch protection. Disabling this would create alerts to the manager but allowed an on-call developer to make an emergency bug fix at 2am and get a postmortem review the next day.

  • permalink
  • fedilink
  • source
  • parent
  • [–] [S] 2 points 2 months ago

    Good distinction. If it's useful, GitHub lets you require checks and still grant a bypass for specific people or teams, so the hard rule and the emergency escape hatch can coexist, and the scan reads that as passing. Could be you've already weighed that, in which case ignore me.

  • permalink
  • fedilink
  • source
  • parent