▲ 27 ▼ The Pain That is GitHub Actions - Feldera Blog (www.feldera.com) submitted 1 year ago by Kissaki@programming.dev to c/programming@programming.dev 27 comments fedilink hide all child comments
[–] FizzyOrange@programming.dev 4 points 1 year ago (1 child) To check that people ran the pre-commit linters. Committing itself won’t be possible That's not how pre-commit hooks work. They're entirely optional and opt-in. You need CI to also run them to ensure people don't forget. permalink fedilink source parent hideshow 2 child comments replies: [–] lemmeBe@sh.itjust.works [B] -2 points 1 year ago (1 child) They're optional if you make them optional. I didn't. You do as you please. 😄 permalink fedilink source parent hideshow 2 child comments replies: [–] FizzyOrange@programming.dev 5 points 1 year ago (1 child) No, they're inherently optional in Git. There's no way to "check in" a git hook. You have to put in your README Clone the repo and then please run pre-commit install! Oh and whatever you do don't git commit --no-verify! You definitely need to actually check the lints in CI. It's very easy though, just add pre-commit run -a to your CI script. permalink fedilink source parent hideshow 2 child comments replies: [–] bamboo@lemm.ee 2 points 1 year ago pre-commit also has a free service for open source GitHub repos too. They’ll even push an autofix commit for you if your tools are configured for it permalink fedilink source parent
[–] lemmeBe@sh.itjust.works [B] -2 points 1 year ago (1 child) They're optional if you make them optional. I didn't. You do as you please. 😄 permalink fedilink source parent hideshow 2 child comments replies: [–] FizzyOrange@programming.dev 5 points 1 year ago (1 child) No, they're inherently optional in Git. There's no way to "check in" a git hook. You have to put in your README Clone the repo and then please run pre-commit install! Oh and whatever you do don't git commit --no-verify! You definitely need to actually check the lints in CI. It's very easy though, just add pre-commit run -a to your CI script. permalink fedilink source parent hideshow 2 child comments replies: [–] bamboo@lemm.ee 2 points 1 year ago pre-commit also has a free service for open source GitHub repos too. They’ll even push an autofix commit for you if your tools are configured for it permalink fedilink source parent
[–] FizzyOrange@programming.dev 5 points 1 year ago (1 child) No, they're inherently optional in Git. There's no way to "check in" a git hook. You have to put in your README Clone the repo and then please run pre-commit install! Oh and whatever you do don't git commit --no-verify! You definitely need to actually check the lints in CI. It's very easy though, just add pre-commit run -a to your CI script. permalink fedilink source parent hideshow 2 child comments replies: [–] bamboo@lemm.ee 2 points 1 year ago pre-commit also has a free service for open source GitHub repos too. They’ll even push an autofix commit for you if your tools are configured for it permalink fedilink source parent
[–] bamboo@lemm.ee 2 points 1 year ago pre-commit also has a free service for open source GitHub repos too. They’ll even push an autofix commit for you if your tools are configured for it permalink fedilink source parent