▲ 39 ▼ What should semantic diffs highlight: The change or its effect? (semanticdiff.com) submitted 2 years ago by DarkPlayer@lemmy.world to c/programming@programming.dev 19 comments fedilink hide all child comments
[–] Bogasse@lemmy.ml 4 points 2 years ago (1 child) Then with a code formatter you definitely want to show this change. In a normal usage the code formatter should ensure that this kind of diff can't happen, then it's useful to see if it was not used during a code review. permalink fedilink source parent hideshow 2 child comments replies: [–] brian@programming.dev 2 points 2 years ago (1 child) just stick a verification task in ci. if I have to check if the format matches the standard in a code review instead of reviewing meaningful things my time is being wasted permalink fedilink source parent hideshow 2 child comments replies: [–] Bogasse@lemmy.ml 1 point 2 years ago Yeah exactly, I'm not it was clear that it was what I meant by "the formatter should ensure ..." permalink fedilink source parent
[–] brian@programming.dev 2 points 2 years ago (1 child) just stick a verification task in ci. if I have to check if the format matches the standard in a code review instead of reviewing meaningful things my time is being wasted permalink fedilink source parent hideshow 2 child comments replies: [–] Bogasse@lemmy.ml 1 point 2 years ago Yeah exactly, I'm not it was clear that it was what I meant by "the formatter should ensure ..." permalink fedilink source parent
[–] Bogasse@lemmy.ml 1 point 2 years ago Yeah exactly, I'm not it was clear that it was what I meant by "the formatter should ensure ..." permalink fedilink source parent